ploeh / Hyprlinkr

A URI building helper library for ASP.NET Web API
MIT License
198 stars 34 forks source link

Support for Async controller methods #20

Closed khorvat closed 10 years ago

khorvat commented 11 years ago

Hi,

do you plan to add support for async controllers ?

btw great library.

Thanks

ploeh commented 11 years ago

'Plan' is such a big word, but I've considered it :)

I think it's a good idea.

khorvat commented 11 years ago

Just to be clear, if I pass in the async method without awaiting or invoking result your code works, but VS is raising warnings all over the place.

So if there is a room in your 'plan' it would be nice to kill those warnings.

Thanks

On Sep 18, 2013, Mark Seemann notifications@github.com wrote:

'Plan' is such a big word, but I've considered it :)

I think it's a good idea.


Reply to this email directly or view it on GitHub: https://github.com/ploeh/Hyprlinkr/issues/20#issuecomment-24695331

-- Sent from my Android phone with K-@ Mail. Please excuse my brevity.

ploeh commented 10 years ago

The problem with adding support for this right now is that in order to do that, I'd have to upgrade Hyprlinkr to target .NET 4.5, and right now it only supports .NET 4.0.

However, the up-coming Web API 2 (version 5.0.0 AFAICT) seems to support only .NET 4.5, so it seems reasonable to upgrade Hyprlinkr at that time too. After that, I'll add support for async controllers.

ploeh commented 10 years ago

I found a way to implement this on .NET 4.0, so the latest version of Hyprlinkr (0.9.9) now supports async Controller methods like this:

Uri actual = linker.GetUriAsync((AsyncController c) => c.Get(id)).Result;
khorvat commented 10 years ago

Great, I'll give it a try and let you know how it goes.

Thanks

khorvat commented 10 years ago

Just to confirm that everything is working as expected - without warnings ;) ... thanks again.

ploeh commented 10 years ago

Thank you for reporting back :)

barbosatek commented 7 years ago

AsyncController is MVC specific, do you have any workaround for WebAPI?

khorvat commented 7 years ago

Hi @barbosatek, the above example is working in WebAPI so could you give us an example if the issue you have ?

ploeh commented 7 years ago

AsyncController is MVC specific, do you have any workaround for WebAPI?

Discussion moved to #42