search

ploeh / Hyprlinkr

A URI building helper library for ASP.NET Web API
MIT License
197 stars 34 forks source link

Web API 2 and RouteAttribute handling in DefaultRouteDispatcher #36

Closed MatthewRichards closed 9 years ago

MatthewRichards commented 9 years ago

Further to PR https://github.com/ploeh/Hyprlinkr/pull/35 and issue https://github.com/ploeh/Hyprlinkr/issues/30, this PR covers:

Sorry, this breaks the rule about putting one thing in each PR... But the individual commits are reasonably granular so I can pull out into separate chunks if necessary.

A lot of diff for not very much change - the notable "real code changes" are:

Feedback welcomed! (No rush - I've been ages getting round to this)

andresmoschini commented 9 years ago

Hi @MatthewRichards, I was trying to add it in a ASP.NET 5 Preview Web API project, without success.

Do you have any idea about how to do it?

MatthewRichards commented 9 years ago

Hi @andresmoschini, are you referring to this pull request in particular or Hyprlinkr in general? I haven’t looked into running either against ASP.NET 5 – I would imagine that this new v2 build of Hyprlinkr would stand very slightly more chance of working since it’s built against Web API 2 rather than 1, but I haven’t investigated how compatible Web API 2 and ASP.NET 5 are.

From: Andres Moschini [mailto:notifications@github.com] Sent: 28 April 2015 20:19 To: ploeh/Hyprlinkr Cc: Matthew Richards Subject: Re: [Hyprlinkr] Web API 2 and RouteAttribute handling in DefaultRouteDispatcher (#36)

Hi @MatthewRichardshttps://github.com/MatthewRichards, I was trying to add it in a ASP.NET 5 Preview Web API project, without success.

Do you have any idea about how to do it?

— Reply to this email directly or view it on GitHubhttps://github.com/ploeh/Hyprlinkr/pull/36#issuecomment-97174670.

Matthew Richards | Technical Director Tel : 020 7485 7500 ext 3212 | Fax : 020 7485 7575

softwire Sunday Times Best Small Companies - UK top 25 five years running Web : www.softwire.comhttp://www.softwire.com/ | Addr : 325 Highgate Studios, 53-79 Highgate Road, London NW5 1TL Softwire Technology Limited. Registered in England no. 3824658. Registered Office : 13 Station Road, London N3 2SB

andresmoschini commented 9 years ago

Thanks for your response @MatthewRichards, I was referring to this particular PR. But, maybe Hyprlinkr is not necessary in MVC 6.

ploeh commented 9 years ago

Thank you for your contribution! It's now live as Hyprlinkr 2.0.0.

MatthewRichards commented 9 years ago

Great, thanks!

ploeh commented 9 years ago

@MatthewRichards Do you have a Twitter profile?

I usually tweet out whenever there's a new major or minor version of any of the open source projects I take care of, and give credits to contributors if they want it.

MatthewRichards commented 9 years ago

My (fairly quiet!) Twitter profile is: RichardsMatthew (https://twitter.com/RichardsMatthew).

ploeh commented 9 years ago

Not quiet for long now, I think :smile: