search

ploeh / Hyprlinkr

A URI building helper library for ASP.NET Web API
MIT License
198 stars 34 forks source link

Removed IDisposable from RouteLinker #9

Closed dhilgarth closed 11 years ago

dhilgarth commented 11 years ago

See #4.

ploeh commented 11 years ago

Thanks. The code is now in master. However, I had to make some other changes to master before, so your fork is behind, which is (I think) the reason why github isn't automatically closing the pull request. I can force close it manually, but wonder what happens if you do this:

  1. git fetch origin (assuming you call the 'official' hyprlinkr repo origin)
  2. git rebase origin/master
  3. git checkout bug/RemoveIDisposable
  4. git rebase master
  5. git push dhilgarth bug/RemoveIDisposable (assuming you call your own fork dhilgarth)

If my theory is correct, that should automatically close the pull request, but I wouldn't be surprised if I'm wrong either...

dhilgarth commented 11 years ago

I will try that. FYI: There are three repositories involved here.

  1. ploeh/Hyprlinkr
  2. dhilgarth/Hyprlinkr
  3. My local repository

In my local repository dhilgarth/Hyprlinkr is "origin" and ploeh/Hyprlinkr is "ploeh". That's how things have been created automatically - I guess by github.