search

ploigos / ploigos-containers

Container image definitions for the Ploigos project.
GNU General Public License v3.0
7 stars 14 forks source link

Is the latest v2.0.0-rc4 ? #121

Open jimmyliangacn opened 1 month ago

jimmyliangacn commented 1 month ago

Looking through the feature branches that may be the latest but yet pulled into main. Can the project maintainers merge this to main and cut a release please? Latest release is 1.0.0 in 2021.

Perhaps @itewk @twling can help? CC: @HunterGerlach and @bcarr-redhat as you made the latest commit to 2.0.0-rc4

dwinchell commented 1 month ago

Hi @jimmyliangacn. Do you mean feature branches that have not been pulled into main?

To my knowledge, none of those unmerged feature branches are finished, as in not functional and passing tests. That's why they were never merged. I know for sure that's the case with feature/cypress. Perhaps we should have deleted them to avoid confusion.

To be honest this project is not very actively maintained anymore, though you may get some responses or offers to help. If you're passionate about continuing it, as long as the other maintainers agree, I'd be okay giving you maintainer access if you want it.

jimmyliangacn commented 1 month ago

My apologies - I was talking about feature/2.0.0rc4 (I had it in the title, but not the description/body).

I have worked with Ben before so I can ask him to see if he could wrap up his work on his branch and create the PR.

For the project I am supporting we are using Ploigos. Once I get a project GitHub setup then I think we can look into having maintainer access established.

itewk commented 1 month ago

@jimmyliangacn happy to help. but unclear what being asked. can you link to what you are looking to be merged?

jimmyliangacn commented 1 month ago

I'd like to see if @bcarr-redhat (or someone) can merge feature/2.0.0rc4 into main. I don't want to speak for Ben here but if we don't hear back from him then I suppose I can take the initiative and create the PR in his behalf.

bcarr-rh commented 1 month ago

I'll take a look!

bcarr-rh commented 1 month ago

PLOIGOS_SOURCE

I believe this arg is set elsewhere and 1.0.0 is the default value. I thank that is the only change in the branch. Everything else was already merged into main from https://github.com/ploigos/ploigos-containers/commit/537762d7823987a84166489b83686a3f3e4f653f

bcarr-rh commented 1 month ago

do we want to cut a release for https://github.com/ploigos/ploigos-containers/tree/v2.0.0-rc4 ? @itewk @dwinchell

itewk commented 1 month ago

do we want to cut a release for https://github.com/ploigos/ploigos-containers/tree/v2.0.0-rc4 ? @itewk @dwinchell

@bcarr-rh do it.

jimmyliangacn commented 1 month ago

Thanks @bcarr-rh. Just wondering - should the release be something like 2.0.0 or 2.0.1 instead of -rc4 which I think stands for "release candidate #4"?

itewk commented 1 month ago

@bcarr-rh and @jimmyliangacn , yes, it shoudl be released as v2.0.0. you may also want to update the cli tools version to something newer...