search

ploigos / ploigos-containers

Container image definitions for the Ploigos project.
GNU General Public License v3.0
6 stars 14 forks source link

ploigos-tool-containers - add s2i #92

Closed itewk closed 3 years ago

itewk commented 3 years ago

Purpose

add s2i to ploigos-tool-containers

Breaking?

No

Integration Testing

dwinchell commented 3 years ago

@itewk looks good. why did we need this?

cthiel1 commented 3 years ago

@dwinchell client user needs it. The dev team we want to onboard is using S2I builds, not container files, and we're going to work to build that into the psr over the next few days

itewk commented 3 years ago

had to update the base ploigos-tool-container image to have a podman socket since s2i expects a dockersocket to interact with.

itewk commented 3 years ago

had to update the base ploigos-tool-container image to have a podman socket since s2i expects a dockersocket to interact with.

actually. wrong. so s2i only works with docker when doing the container build. https://cloud.redhat.com/blog/openshift-4-image-builds

BUUUUT

there is s2i build . registry.redhat.io/ubi8/php-74:latest --dockercfg-path ~/container-registry-auth --as-dockerfile Containerfile which will build a container file that you can then do buildah bud Containerfile sooo....we have a pretty clean path forward. have an s2i step implementer that crteates a containerfile, then call the existing buildah stepimplmeneter to build that contaienrfile. boom, bang done.