ploigos / ploigos-containers

Container image definitions for the Ploigos project.

GNU General Public License v3.0

7 stars 14 forks source link

Update javascript image to include java to support selenium #97

Closed kharyam closed 2 years ago

kharyam commented 2 years ago

Purpose

Currently, the javascript container image does not contain the java executable. There are cases where java is required, most notably when running UAT tests via selenium.

# Note: selenium is a common framework used for user interface testing and UAT.
#       The npm selenium web driver package requires java in order to execute
#       selenium tests. For this reason, java is used as the base image

Breaking?

No

Integration Testing

itewk commented 2 years ago

@kharyam can you add the note to https://github.com/ploigos/ploigos-containers/blob/main/ploigos-tool-javascript/README.md

jkeam commented 2 years ago

I gotta say I love the emojis in the step names 🎉👍👻

itewk commented 2 years ago

I gotta say I love the emojis in the step names 🎉👍👻

is it a github workflow if it doesn't have emojoies in it?

kharyam commented 2 years ago

@kharyam can you add the note to https://github.com/ploigos/ploigos-containers/blob/main/ploigos-tool-javascript/README.md

@kharyam bumping this. Also can you update the commit message to include "... to support selenium testing" or something to that affect?

Updated, thanks!

itewk commented 2 years ago

@kharyam if you didnt see, looks like some build error for the maven images. but i didn't think you touched those....maybe something broke outside of your PR?

itewk commented 2 years ago

@kharyam seems like we should do the maven version change in a seperate PR, or at least make it a seperate commit. seems to not be "the fault of this change" but just an issue blocking you. sorry for the pain.

kharyam commented 2 years ago

@kharyam if you didnt see, looks like some build error for the maven images. but i didn't think you touched those....maybe something broke outside of your PR?

Thanks @itewk - maven version 3.8.1 is no longer available, bumped to the latest patch release 3.8.3

itewk commented 2 years ago

@kharyam if you didnt see, looks like some build error for the maven images. but i didn't think you touched those....maybe something broke outside of your PR?

Thanks @itewk - maven version 3.8.1 is no longer available, bumped to the latest patch release 3.8.3

Heyo @kharyam sory to be a pain, but can you seperate the maven change into its own commit, can leave it in this PR for simplicity if you want, but at least having a clear history of when we bumped maven version would be good.

kharyam commented 2 years ago

@kharyam if you didnt see, looks like some build error for the maven images. but i didn't think you touched those....maybe something broke outside of your PR?

Thanks @itewk - maven version 3.8.1 is no longer available, bumped to the latest patch release 3.8.3

Heyo @kharyam sory to be a pain, but can you seperate the maven change into its own commit, can leave it in this PR for simplicity if you want, but at least having a clear history of when we bumped maven version would be good.

@itewk no problem - done

itewk commented 2 years ago

@kharyam thanks