search

ploigos / ploigos-github-workflows

Apache License 2.0
0 stars 0 forks source link

Break out psr steps into separate jobs #42

Closed aarongreen85 closed 2 years ago

aarongreen85 commented 2 years ago

Success criteria: There are at minimum separate jobs for setup, image, deploy, and report.

aarongreen85 commented 2 years ago

Thoughts during implementing. Does this break the upgrade of psr in the workflow? If I understand correctly, that step will run on a pod and then when the next job kicks off another pod will likely run through those steps, which won't have the upgraded psr? It'll get the psr version that is part of the container image? @dwinchell

dwinchell commented 2 years ago

Good point. If we want to download the psr in an action AND split the pipeline into multiple jobs, we need to do this: https://docs.github.com/en/actions/creating-actions/developing-a-third-party-cli-action

We could also take out the upgrade and see how annoying that becomes. So far we haven't had to do much hacking on the PSR.