search

ploigos / ploigos-software-factory-operator

33 stars 22 forks source link

Improve handling of KeycloakClient CRs and client secrets. #159

Closed adamgoossens closed 3 years ago

adamgoossens commented 3 years ago

This ensures that the KeycloakClient secret is not regenerated on each reconcilation loop. We also no longer generate a password and instead allow the Keycloak operator to do so - when the Client is created on the server a UUID is generated for the client secret, which the Operator then fetches and stores in the Secret.

Unfortunately, this change means that Gitea config no longer has a simple means to identify when the client-secret has changed and issue the update-oauth commands, and so with this change that capability is removed. This should probably end up being a function of the Gitea operator (e.g. watching for last updated times of the corresponding Secret compared with the last reconciliation time of the CR).

adamgoossens commented 3 years ago

CI run is failing because the rht-set cluster is offline at the moment.

adamgoossens commented 3 years ago

@andykrohg done :)

andykrohg commented 3 years ago

Good to merge once tests pass