search

ploigos / ploigos-step-runner

Ploigos Step Runner (PSR) implemented as a Python library.
GNU General Public License v3.0
20 stars 66 forks source link

Enable asynchronous sync step and use wait to watch for sync completion #267

Closed aarongreen85 closed 2 years ago

aarongreen85 commented 2 years ago

Purpose

In order to provide a working solution around this argocd cli upstream issue, we've changed the app sync to be asynchronous and then used the following wait to watch for the sync to complete.

Breaking?

No, the workflow was breaking prior to this fix.

Integration Testing

Example successful workflows - https://github.com/ploigos/spring-petclinic/actions https://github.com/ploigos/java-github-example/actions

itewk commented 2 years ago

Squash commits and fix tests and looks good to me

codecov[bot] commented 2 years ago

Codecov Report

Merging #267 (66a5924) into main (bb2ac17) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 66a5924 differs from pull request most recent head 6d30877. Consider uploading reports for the commit 6d30877 to get more accurate results

@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99        99           
  Lines         4188      4189    +1     
=========================================
+ Hits          4188      4189    +1
Flag Coverage Δ
pytests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._runner/step_implementers/shared/argocd_generic.py 100.00% <ø> (ø)
...er/step_implementers/uat/maven_integration_test.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb2ac17...6d30877. Read the comment docs.

dwinchell commented 2 years ago

Pair programmed with @aarongreen85 and @gfulton-redhat

dwinchell commented 2 years ago

Successful Integration test w/ Tekton everything pipeline - https://console-openshift-console.apps.a95115fc.eastus.aroapp.io/k8s/ns/devsecops/tekton.dev~v1beta1~PipelineRun/reference-quarkus-mvn--feature-demo-nrrfc