ploigos / ploigos-step-runner

Ploigos Step Runner (PSR) implemented as a Python library.
GNU General Public License v3.0
20 stars 66 forks source link

Add mvn note to development/test section in README #289

Closed RyanMillerC closed 2 years ago

RyanMillerC commented 2 years ago

Purpose

Project should call out that mvn is required in development setup.

Following dev setup instructions and running tox test will result in an error for tests/step_implementers/generate_metadata/test_maven_generate_metadata.py::TestStepImplementerMavenGenerateMetadata::test_run_step_pass if the mvn command isn't available.

E       sh.CommandNotFound: mvn

.venv/lib/python3.9/site-packages/sh.py:3457: CommandNotFound

Might save somebody time troubleshooting 🤷

Breaking?

No

codecov[bot] commented 2 years ago

Codecov Report

Merging #289 (e557058) into main (d0a7f54) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         4202      4202           
=========================================
  Hits          4202      4202           
Flag Coverage Δ
pytests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

RyanMillerC commented 2 years ago

I opened #290 that has this change and more.