Generate a valid `Automatic-Module-Name` attribute

plokhotnyuk / jsoniter-scala

Scala macros for compile-time generation of safe and ultra-fast JSON codecs + circe booster

MIT License

750 stars 99 forks source link

Generate a valid `Automatic-Module-Name` attribute #1201

Closed hubertp closed 2 months ago

hubertp commented 2 months ago

jsoniter-scala-core is not a valid Java identifier because of dashes in the name, making it impossible to import the module:

> jar --describe-module -f jsoniter-scala-core_2.13-2.28.5.jar
Unable to derive module descriptor for: jsoniter-scala-core_2.13-2.28.5.jar
Automatic-Module-Name: jsoniter-scala-core: Invalid module name: 'jsoniter-scala-core' is not a Java identifier

This change uses dots instead of dashes making it a valid Java identifier.

plokhotnyuk commented 2 months ago

@hubertp Thanks for your PR!

Please peek the latest release with a fix: https://github.com/plokhotnyuk/jsoniter-scala/releases/tag/v2.30.12