search

plokko / firebase-php

Php integration of Firebase API (FCM Http v1, RealTime database)
16 stars 9 forks source link

added fcm options to webpush #8

Closed andrewalf closed 5 years ago

andrewalf commented 5 years ago

One parameter from docs was missing, 'fcm_options'. For example, this param is used for redirection link on webpush notification click

https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#WebpushConfig

plokko commented 5 years ago

Shouldn't we implement it as a WebpushFcmOptions object instead of array? For now it just have a link parameter but it seems more clean. https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#WebpushFcmOptions

andrewalf commented 5 years ago

Yep, totally agree with you. Added WebpushFcmOptionsn object

plokko commented 5 years ago

Thanks again for the contribution! :)