search

plomino / plomino.tinymce

Plomino TinyMCE Integration is a plugin for Plomino which allows to manage easily Plomino objects (fields, actions and hidewhen) from the TinyMCE interface.
1 stars 2 forks source link

plomino accordion button not deactivated on non plomino RTE fields #4

Open gaudenz opened 12 years ago

gaudenz commented 12 years ago

Other than all the other plomino.tinymce buttons the accordion button is not deactiviated on non plomino RTE form fields. As it's not usable on non plomino fields it should be deactivated as well.

Is there a way to completely hide the buttons instead of just deactivating them? I think these buttons are somewhat confusing to simple content editors not aware of plomino even when deactivated.

ebrehault commented 12 years ago

Regarding accordion: it is actually usable outside plomino (it is just a jqueryUI feature that can work in the entire Plone site). So we considered it was nice to keep it everywhere but I agree it can be confusing, so the best thing would be to control that through configuration.

Regarding the other buttons: the easiest way we found was to disable them (using ed.controlManager.setDisabled), but if you know a way to hide them, it would be much better.

More generally about TinyMCE: the TinyMCE version used in Plone is quite old and some people are currently working on upgrading it. I hope the new version will provide interesting integration mechanisms, so we can improve plomino.tinymce.

gaudenz commented 12 years ago

On Mon, 2 Apr 2012 12:42:32 -0700, Eric BREHAULT reply@reply.github.com wrote:

Regarding accordion: it is actually usable outside plomino (it is just a jqueryUI feature that can work in the entire Plone site). So we considered it was nice to keep it everywhere but I agree it can be confusing, so the best thing would be to control that through configuration.

Yes that would be nice. I did not know that it's actually just the accordion plugin without any plomino specific functionality.

Regarding the other buttons: the easiest way we found was to disable them (using ed.controlManager.setDisabled), but if you know a way to hide them, it would be much better.

No I don't know TinyMCE that well. That's why I just submitted this report instead of providing a patch...

More generally about TinyMCE: the TinyMCE version used in Plone is quite old and some people are currently working on upgrading it. I hope the new version will provide interesting integration mechanisms, so we can improve plomino.tinymce.

Yes I know that. Progress is going very slow... Don't know what the new TinyMCE will bring us.

Gaudenz

Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. ~ Samuel Beckett ~

ebrehault commented 12 years ago

I see there is a controlManager.destroy() method, but I do not know if it is supported in the current version

I will give it a try