Earlier versions of TinyMCE break Plomino by calling forms.

plomino / plomino.tinymce

Plomino TinyMCE Integration is a plugin for Plomino which allows to manage easily Plomino objects (fields, actions and hidewhen) from the TinyMCE interface.

1 stars 2 forks source link

Earlier versions of TinyMCE break Plomino by calling forms. #8

Closed jean closed 11 years ago

jean commented 11 years ago

A condition in tinymce_wysiwyg_support.pt rendered form objects, triggering events. Current TinyMCE uses 'nocall:', so doesn't do this.

jean commented 11 years ago

Plone pins specific TinyMCE versions. 4.1.5 pins 1.2.11 which is too old for current Plomino. 4.2.2 pins 1.2.13 -- newer TinyMCE doesn't work for Plone.

If we want to have Plomino working with older Plone versions, I think we have to monkeypatch or override (templates) TinyMCE if possible. plomino.tinymce would be the logical place to do this. Overrides would have to be tied to specific Plone/TinyMCE versions, so that we can verify we don't break things.

ebrehault commented 11 years ago

If we do that, we break Plomino compliancy with older versions of Plone. I propose we create 2 versions of plomino.tinymce:

one with your fix in setup.py, that will be used for Plone >= 4.2.2
one with an override to fix the Tinymce guilty template, that will be used for Plone < 4.2.2

And in Plomino we provide a specific buildout to pin the appropriate version.