search

plone / Plone

The Plone CMS: root integration package
https://plone.org
239 stars 51 forks source link

Fixed typos and corrected Grammar #22

Closed knight-95 closed 2 years ago

knight-95 commented 2 years ago

Added punctuations wherever necessary, fixed typos

mister-roboto commented 2 years ago

@knight-95 you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 2 years ago

@knight-95 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

knight-95 commented 2 years ago

@jenkins-plone-org please run jobs

davisagli commented 2 years ago

@rohnsha0 Why did you close this pull request?

mister-roboto commented 2 years ago

@knight-95 you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 2 years ago

@knight-95 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

rohnsha0 commented 2 years ago

@davisagli As I've already done the same thing... As well as corrected Discord link.... So I thought that it won't make any sense... Nevertheless, if it wasn't to be done... I apologise!

davisagli commented 2 years ago

@rohnsha0 oh okay, I didn't see your pull request #23

rohnsha0 commented 2 years ago

@davisagli #23 it is open for review!