search

plone / Products.CMFPlacefulWorkflow

Plone product that allows you to define workflow policies that define content type to workflow mappings that can be applied in any sub-folder of your Plone site
1 stars 5 forks source link

Move image from skin to browser resource #33

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 4 years ago

We have a skins directory with as only content an icon: placefulworkflow_icon.png.

It is used in two places. Probably needs an upgrade step to fix the image url in the control panel.

We could also add it now, and keep the two for a while.

Once removed, we can remove the skins directory (which would also be an upgrade step).

I think we should remove the image and skins directory in Plone 6.0.

mauritsvanrees commented 2 years ago

I had a look. We don't need a browser resource. In controlpanel.xml we can use icon_expr="string:toolbar-action/workflow". But this only works in Plone 6, as it uses the new icon resolver. So we would need to create a branch for Plone 5 first. Seems fine, not much is happening in this repo.

I quickly tried the icon. It looks like this in the overview control panel:

Screenshot 2021-12-22 at 22 36 14