plone / Products.CMFPlacefulWorkflow

Plone product that allows you to define workflow policies that define content type to workflow mappings that can be applied in any sub-folder of your Plone site
1 stars 5 forks source link

Remove request.SESSION code from tests. #35

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 3 years ago

I accidentally already did this on master instead of in a PR. See commit e0c458f9d65bf98b127e929c91eecc86965ce14a. I have created this issue to make the change a bit more visible.

After this commit, the only code in core Plone 6 that really uses request.SESSION is in Products.PluggableAuthService in the SessionAuthHelper plugin and in its csrf protection code. The session auth helper is not installed by default, and plone.protect overrides the csrf protection with its own code. For more information and links, see https://github.com/zopefoundation/Products.PluggableAuthService/issues/72.