plone / Products.CMFPlacefulWorkflow

Plone product that allows you to define workflow policies that define content type to workflow mappings that can be applied in any sub-folder of your Plone site
1 stars 5 forks source link

1letter/bs5 #42

Closed 1letter closed 2 years ago

1letter commented 2 years ago

Update Page Templates, make it ready for use in Plone 6 with Bootstrap 5

mister-roboto commented 2 years ago

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

agitator commented 2 years ago

Updated overall markup to align with Plone 6 controlpanels - used https://github.com/plone/plone.app.contentrules as template

Updated translations https://github.com/collective/plone.app.locales/pull/349 probably some more things to look over...

Todo:

1letter commented 2 years ago

@agitator if we rename the configlet url, then an upgrade step is needed, because the url of the action in portal_controlpanel changed. should this go to plone.app.upgrade or should we handle this in this package?

Update I see there is an existing upgrade step profile in this package registered. i would add a new step.

agitator commented 2 years ago

I'd add the upgrade steps here. cc @mauritsvanrees

mauritsvanrees commented 2 years ago

I'd add the upgrade steps here. cc @mauritsvanrees

Indeed.

1letter commented 2 years ago

if i adjust the name of browserviews, like suggested by @agitator , a change in plone.app.contentmenu is needed.

1letter commented 2 years ago

@mauritsvanrees if all tests green, this can only merged with this pr in plone.app.contentmenu

agitator commented 2 years ago

one more thing... view calls should all be done with @@ ... quicker and less acquisition magic ;-)