plone / Products.CMFPlacefulWorkflow

Plone product that allows you to define workflow policies that define content type to workflow mappings that can be applied in any sub-folder of your Plone site
1 stars 5 forks source link

Config with default template 0d2f9357 #47

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Something funky wrong with plone.app.robotframework in the tests though.

test: commands[1]> pytest
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.10.9, pytest-7.2.1, pluggy-1.0.0
cachedir: .tox/test/.pytest_cache
rootdir: /Users/maurits/community/plone-coredev/6.0/src/Products.CMFPlacefulWorkflow
plugins: gocept.pytestlayer-8.1
collected 0 items / 2 errors                                                                                                                                 

=========================================================================== ERRORS ===========================================================================
___________________________________________ ERROR collecting Products/CMFPlacefulWorkflow/tests/test_configlet.py ____________________________________________
ImportError while importing test module '/Users/maurits/community/plone-coredev/6.0/src/Products.CMFPlacefulWorkflow/Products/CMFPlacefulWorkflow/tests/test_configlet.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/Cellar/python@3.10/3.10.9/Frameworks/Python.framework/Versions/3.10/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
Products/CMFPlacefulWorkflow/tests/test_configlet.py:27: in <module>
    from Products.CMFPlacefulWorkflow.tests.CMFPlacefulWorkflowTestCase import (  # noqa: E501
Products/CMFPlacefulWorkflow/tests/CMFPlacefulWorkflowTestCase.py:20: in <module>
    from Products.CMFPlacefulWorkflow.testing import (
Products/CMFPlacefulWorkflow/testing.py:1: in <module>
    from plone.app.contenttypes.testing import PLONE_APP_CONTENTTYPES_FIXTURE
.tox/test/lib/python3.10/site-packages/plone/app/contenttypes/testing.py:3: in <module>
    from plone.app.event.testing import PAEvent_FIXTURE
.tox/test/lib/python3.10/site-packages/plone/app/event/testing.py:2: in <module>
    from plone.app.robotframework.testing import AUTOLOGIN_LIBRARY_FIXTURE
E   ModuleNotFoundError: No module named 'plone.app.robotframework'
mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!