plone / Products.CMFPlacefulWorkflow

Plone product that allows you to define workflow policies that define content type to workflow mappings that can be applied in any sub-folder of your Plone site
1 stars 5 forks source link

Ported to plone.app.testing #6

Closed tomgross closed 10 years ago

tomgross commented 10 years ago

Ported tests to plone.app.testing Radically removed very old stuff pep8 and frosted cleanup

pbauer commented 9 years ago

This breaks tests in plone.app.upgrade with No module named portal_placeful_workflow (see http://jenkins.plone.org/job/plone-5.0-python-2.7/3780/testReport/). So i reverted adding it as a checkout to coredev (https://github.com/plone/buildout.coredev/commit/78781eee06f0eb0f4f9c514c98ff8337bdf2115c)

@tomgross Can you fix this? I really want to have this since it solved some inconsistencies. The old test-setup of CMFPlacefulWorkflow ran plone.app.blob's __init__.py when running some packages single test with -t while running all tests of a package with -s did not.

tomgross commented 9 years ago

Do we really need / want to include the full stack migration (tests) from Plone 3 to Plone 5? I'm in favour to drop the the (tests) for everything below Plone 4 and document to port a Plone 3 first to Plone 4 and then Plone 5 or use transmogrifier. This would make maintaining the tests and backwards compatibility so much easier.

gforcada commented 9 years ago

:+1: on @tomgross approach, IMHO if too old code for bbb or migrations or so is keeping us from moving forward we need to, at certain defined points, remove part of them to ease our day to day work on improving the code base.

tisto commented 9 years ago

@tomgross +1

pbauer commented 9 years ago

@tomgross :+1: