plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
246 stars 187 forks source link

PLIP: New image widget #1488

Closed vangheem closed 8 years ago

vangheem commented 8 years ago

Proposer : vangheem

Seconder : pigeonflight

Abstract

I propose an advanced image widget that allows users to crop and resize the image before they upload.

Motivation

Give user ability to crop, resize before they upload to the server. Also, give user inline preview of image they are uploading.

Assumptions

Proposal & Implementation

hvelarde commented 8 years ago

sounds pretty interesting

pigeonflight commented 8 years ago

+200

jensens commented 8 years ago

I'am not sure if i want to be able to resize/crop at upload in general. I'm -1 to have this by default. Fine as addon or as an option on the image widget.

IMO much more important would be an async upload, which survives form validation errors.

Btw.: I'm just at an overhaul of p.a.imagecropping: https://github.com/collective/plone.app.imagecropping/pull/74

This shows also a bit the complexity of the whole cropping story which I fear can not be handled good before upload in a general and generic way.

thet commented 8 years ago

sorry for the close/reopen

gforcada commented 8 years ago

If it's a new image widget then one could still select either this one or the current plain old one? In general I'm in favor of having this one in core, but at the same time it could be a good idea to also keep the plain upload, as one could want to upload icons or other kind of imagery that do not need resize/cropping and/or have been already been done by professionals beforehand.

jensens commented 8 years ago

yes, it can be in core, i.e. provided as an alternative behavior one can swap with the default one. But please do not use it as default.

thet commented 8 years ago

@vangheem this PLIP was rejected. Among the reasons were: Cropping on upload is the wrong place (better on uploaded images) and this should better live as an add on. If you feel this needs a re-evaluation, please provide more context and use cases and discuss it with us!

ebrehault commented 8 years ago

The PLIP has been rejected. See https://community.plone.org/t/framework-team-meeting-minutes-2016-04-12/1943

datakurre commented 8 years ago

@jensens As a solution for "async upload, which survives validation errors", plone.app.drafts (bundled with Mosaic) could be fixed to work. It saves a draft on every ajax-validation, but currently only when validation passes. But it could be fixed to always save uploads.

espenmn commented 8 years ago

Slightly related (or at least interesting if too big images are a problem): https://pypi.python.org/pypi/collective.autoscaling/1.0