search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
246 stars 187 forks source link

Actions with no icons are not visible on collapsed toolbar #1569

Closed hvelarde closed 7 years ago

hvelarde commented 8 years ago

I have a content type with an action called Update; the action is only visible on the expanded toolbar:

selection_067

With the toolbar collapsed the action is only visible when I hover on it:

selection_068 selection_069

davilima6 commented 8 years ago

We should add a sensible default fallback icon in Plone-Fontello (like #1233) and then allow addons to configure the portal_action's icon_expr to override it (like in #1236).

Not sure what would be the general feeling about this but we could even detect if its value is an unicode codepoint (e.g. '\e80a') - and thus override ::before with an in-page style - or an SVG/PNG (which might require an additional class in the markup to hide the fallback icon).

jensens commented 8 years ago

i'd really love to see svg support using actions icon expressions

alecpm commented 7 years ago

A default icon has been added in 5.0.x and 5.1, a default content type icon has been added to the toolbar menu as well.

alecpm commented 7 years ago

See: https://github.com/plone/plone.app.contentmenu/commit/b022808cd607f3776b6ca93f100aab48c9b0c62e https://github.com/plone/Products.CMFPlone/commit/b3c9e42dda58e9ca94a54ce0d90a55c5e4d64182