plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
246 stars 187 forks source link

Interal link browser should start from current folder and/or should be customizable #1974

Closed tomgross closed 7 years ago

tomgross commented 7 years ago

What I did:

  1. Edit a page nested in a folder structure
  2. Open dialog to insert internal link

What I expect to happen:

Search / Browsing starts at the folder the current page is located

What actually happened:

Search / Browsing starts at Root (next NavRoot) In Plone 4.3 there were two options: Current Folder, Root and it was even custom extendable.

What version of Plone/ Addons I am using:

5.1b2-pending

hvelarde commented 7 years ago

@tomgross an issue can be a bug or a regression, but not both.

hvelarde commented 7 years ago

I just tested and this is a regression from the behavior found in Plone 4.3.

fgrcon commented 7 years ago

a bug which comes back is still a bug but also a regression (what makes it worse) , or i am totally wrong ? :-)

fulv commented 7 years ago

A regression is a specific class of bug.

On Tue, Mar 21, 2017 at 3:53 PM Franz Gerhard Reinisch < notifications@github.com> wrote:

a bug which comes back is still a bug but also a regression (what makes it worse) , or i am totally wrong ? :-)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/plone/Products.CMFPlone/issues/1974#issuecomment-288244569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcHxnnxEpcJUB7v-QKpNWNozlcdIFTtks5roFUFgaJpZM4Mj8tn .

hvelarde commented 7 years ago

a regression is a bug (or a different behavior) introduced (or reintroduced) due to a refactor like in this case; it's something that should not happen if we have tests for a specific use case.

paskyorg commented 7 years ago

I get the same behaviour with Plone 5.0.4. Anyone know if there is a plan to correct it?

thet commented 7 years ago

These issue is among others addressed here:

https://github.com/plone/Products.CMFPlone/pull/2055 https://github.com/plone/mockup/pull/765 https://github.com/plone/plone.app.widgets/pull/159