search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
252 stars 189 forks source link

Get rid of Products.PloneTestCase for plone core packages. #222

Closed tisto closed 10 years ago

tisto commented 10 years ago

grep -R PloneTestCase src/*/setup.py

src/Products.ATContentTypes/setup.py: 'Products.PloneTestCase', src/Products.CMFEditions/setup.py: 'Products.PloneTestCase', src/Products.CMFFormController/setup.py: 'Products.PloneTestCase', src/Products.CMFPlacefulWorkflow/setup.py: 'Products.PloneTestCase', src/Products.CMFPlone/setup.py: 'Products.PloneTestCase', src/Products.LinguaPlone/setup.py: 'Products.PloneTestCase', src/Products.PasswordResetTool/setup.py: 'Products.PloneTestCase', src/Products.PloneTestCase/setup.py:setup(name='Products.PloneTestCase', src/Products.ResourceRegistries/setup.py: 'Products.PloneTestCase', src/Products.contentmigration/setup.py: 'Products.PloneTestCase', 'archetypes.schemaextender']), src/borg.localrole/setup.py: 'Products.PloneTestCase', src/plone.app.content/setup.py: 'Products.PloneTestCase', src/plone.app.controlpanel/setup.py: 'Products.PloneTestCase', src/plone.app.customerize/setup.py: 'Products.PloneTestCase', src/plone.app.form/setup.py: 'Products.PloneTestCase', src/plone.app.iterate/setup.py: 'Products.PloneTestCase', src/plone.app.openid/setup.py: 'Products.PloneTestCase', src/plone.app.portlets/setup.py: 'Products.PloneTestCase', src/plone.app.querystring/setup.py: 'Products.PloneTestCase', src/plone.app.textfield/setup.py: 'Products.PloneTestCase', src/plone.app.upgrade/setup.py: 'Products.PloneTestCase', src/plone.app.users/setup.py: 'Products.PloneTestCase', src/plone.app.versioningbehavior/setup.py: 'Products.PloneTestCase', src/plone.app.viewletmanager/setup.py: 'Products.PloneTestCase', src/plone.browserlayer/setup.py: 'Products.PloneTestCase', src/plone.locking/setup.py: 'Products.PloneTestCase', src/plone.outputfilters/setup.py: 'test': ['Products.PloneTestCase'], src/plone.portlet.static/setup.py: 'Products.PloneTestCase', src/plone.session/setup.py: 'Products.PloneTestCase', src/plone.theme/setup.py: 'Products.PloneTestCase',

tomgross commented 10 years ago

Are ATContentTypes and LinguaPlone Plone core packages in Plone 5?

Removing PloneTestCase from PloneTestCase will be hard ;-)

tisto commented 10 years ago

Good point. The title could be a bit more specific. :)

I'm about to make a list of packages that we want to move to p.a.testing before the Plone 5 release. No Archetypes related packages (we already run them in a separate Jenkins job) and no add-on packages will be included in that list.

For now all plone.* packages that still use PTC are a good starting point.

tomgross commented 10 years ago

Done some :)

https://github.com/plone/plone.app.imaging/pull/8 https://github.com/plone/plone.app.controlpanel/pull/24 https://github.com/plone/plone.app.testing/pull/8

tisto commented 10 years ago

@tomgross Awesome! Thanks so much for working on that! This really brings us a lot closer to a saner test setup and significantly improves our CI test pipeline in the long run!

FYI: I added some tickets for the remaining packages that needs to be moved:

https://github.com/plone/Products.CMFPlone/issues?labels=testing&page=1&state=open

Just in case you want to continue to work on it. ;)

tomgross commented 10 years ago

Some more ...

https://github.com/plone/plone.app.contentrules/pull/6 https://github.com/plone/plone.app.i18n/pull/2 https://github.com/plone/plone.locking/pull/5

I guess this issue can be closed since it has been splitted into seperate ones.

tomgross commented 10 years ago

Closing this. See comment above.