Revert revision breaks in Plone 5.1.2

[tomgross]

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

What I did:

• Activate plone.app.iterate on Plone site
• Create a page
• Edit a page
• Got to /@@historyview and try to revert to any earlier version

What I expect to happen:

• Reverting works

What actually happened:

• An Unauthorized error is raised.

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFCore.FSPythonScript, line 127, in __call__
  Module Shared.DC.Scripts.Bindings, line 322, in __call__
  Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
  Module Products.PythonScripts.PythonScript, line 344, in _exec
  Module script, line 4, in revertversion
   - <FSPythonScript at /Plone/de/die-fhnw/hochschulen/ph/medien-und-oeffentlichkeit/events/revertversion>
   - Line 4
  Module AccessControl.ZopeGuards, line 305, in guarded_import
Unauthorized: import of 'six' is unauthorized

What version of Plone/ Addons I am using:

• Plone 5.1.2
• plone.app.iterate

[tomgross]

The problem was introduced here: https://github.com/plone/Products.CMFEditions/commit/a8c0b41c5ca6fcc0e7d76d0b5a5cf4b9512627fb#diff-248dc9cf5dc608a5c25bf6363bd06585R13

[tomgross]

A workaround is to customize the revertversion script in portal_skins and copy the old version in:

https://github.com/plone/Products.CMFEditions/blob/f02745c856d51b2e63dbc720cadee93a42cb5fe3/Products/CMFEditions/skins/CMFEditions/revertversion.py

[tomgross]

A good solution for 5.2 would to migrate the skins to Browserviews. Didn't we want to get rid of portal_skins for Plone 5.0 already 😉

[hvelarde]

IMO, removal of portal_skins is a breaking change that must be done only in 6.0

[tomgross]

I agree, but shipping with an empty portal_skins was an agreement long ago.