plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
246 stars 187 forks source link

TinyMCE control panel settings are not fully implemented #289

Closed petschki closed 9 years ago

petschki commented 9 years ago

the configuration settings in the tinymce controlpanel aren't implemented completely.

petschki commented 9 years ago

@frisi and me startet to work in this at Plone Conference (see also https://github.com/plone/plone.app.widgets for Plone 4.3.x support) ... still a lot to do. help is much appreciated

we were also thinking about an "advanced integrator" textfield where he can paste his own TinyMCE JSON configuration and overrules the configured one. this is an open discussion. feel free to add your comments here

djay commented 9 years ago

I would really really like to have style_formats be able to be specified in a diazo zip file, possibly in the manifest.cfg. This is because that is the most likely place the actually css that implements those styles is going to come from. It would be great to just write them into the manifest and have them automatically appear in tinymce if the theme is activated rather than a "install on activation" type arrangement. This would help prevent orphan styles should themes be installed and uninstalled. These are the only tinymce settings I think that are appropriate to go into the diazo theme, the others would likely go into the registry which already has GS import/export

I'm not sure we can get rid of GS installed styles however, as also plugins might have a need to install a style. That means there would have to be some kind of merge of styles from two different places.... and this then creates the problem should you want them ordered. But we could always present them as a list with theme styles first and plugin styles second? Perhaps even mention which plugin the style comes from?

On 3 Nov 2014, at 6:06 pm, Peter Mathis notifications@github.com wrote:

@frisi and me startet to work in this at Plone Conference (see also https://github.com/plone/plone.app.widgets for Plone >= 4.3 support) ... still a lot to do. help is much appreciated

• remap/rename non existing features (like context menu) • no more tinymce import/export step. how can an addon developer add/remove style_formats? • advanced integrator JSON Configuration Textfield we were also thinking about an "advanced integrator" textfield where he can paste his own TinyMCE JSON configuration and overrules the configured one. this is an open discussion. feel free to add your comments here

— Reply to this email directly or view it on GitHub.

vangheem commented 9 years ago

@djay checkout https://github.com/plone/plone.app.theming/commit/751cafe61d6984beb48e6498184e43a2f48901db#diff-30514299b029fb886788531572d768c8R37

will that work?

/cc @bloodbare

bloodbare commented 9 years ago

We talk with @petschki and @djay on plone conference.

the diazo only configuration on the manifest allow to define the custom_css on plone 5 so we can have diazo only themes with a custom tinymce inside.

Native support on TinyMCE on Plone 4.3 needs to map the options that had Products.TinyMCE onto the options rendered on the pattern and its what @petschki is talking about.

Native support on TinyMCE on Plone5 needs the same mapping from the control panel interface to the adapter that generats the options for tinymce https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/patterns/tinymce.py In Plone5 we can define the control panel options easy ( so remove the ones that are not needed anymore or add the needed ones) for example I added the pattern related options ( like the css field ). Its still needed to modify the adapter to get the theme content_css in case its defined.