plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
248 stars 187 forks source link

Display Collection in navigation, hide Files and Images #3486

Open pbauer opened 2 years ago

pbauer commented 2 years ago

The default-setting for navigations in Plone 5 and 6 does not show Collections in the navigation (top-bar and portlets). I propose to change that, so that for new sites created with Plone 6 Collections actually show up.

It was so irritating that the demo-folder in https://demo.plone.org/en/demo has a collection but it was not shown that I changed that in the demo-site profile.

I would also change the setting that by default Image and File does not show up. These three are the first settings I usually change in all new projects and I think most people have the same issue.

1letter commented 2 years ago

yes, i do also the same steps

pbauer commented 2 years ago

Pull-requests so far:

Jenkins build with these parameters:

https://github.com/plone/plone.base/pull/4
https://github.com/plone/plone.app.layout/pull/300
https://github.com/plone/Products.CMFPlone/pull/3490
https://github.com/plone/plone.restapi/pull/1359
pbauer commented 2 years ago

@plone/framework-team I don't think this needs to be a plip but I'd like to hear your opinion. Tests are green.

ale-rt commented 2 years ago

Personally, I do not have a big preference here. I do not think it is even a FWT matter.

What it is certain is that the Plone 6 alpha stage is the right moment for changing this kind of stuff.

So if you get large consensus or lack to find anyone against you are free to go.

But this is just my own opinion.

petschki commented 2 years ago

+1000 for merging this!

pbauer commented 2 years ago

What @ericof just said (after I merged everything) was that he also enables Link everytime. I agree that If you actually add a Link you do that so it shows up in the navigation, e.g. "Shop" that points to a external shop. I will add that as well...

pbauer commented 2 years ago

I don't have time right now to add Link to the types shown by default. The fix is rather easy but requires changes in multiple packages and a upgrade-step (see the previous PRs) so it's a great task for a newbie.