Remove all skin layers in Plone 6

[mauritsvanrees]

In Plone 6.0.0a4 only the following skin layers are left.

From Products.CMFPlone:

• [x] plone_templates with two templates. https://github.com/plone/Products.CMFPlone/pull/3516
• [ ] plone_wysiwyg with one template.
• [ ] plone_scripts with ten scripts.
• [ ] plone_images with 27 images. I hope these are not used anymore, but we might not be so lucky.

From Products.CMFPlacefulWorkflow:

• [x] CMFPlacefulWorkflow with one icon. https://github.com/plone/Products.CMFPlacefulWorkflow/pull/40

It would be nice if we could get rid of all of these skin layers. They work, and will continue to be supported (in CMFCore really), but they are an old technique.

[yurj]

plone_images: what is the problem even if they're used? At least you can move the to static/old_icons and drop a note to change the url if used but it is not worth the time.

Beware that the logo seems to be used: https://6-classic.demo.plone.org/logo.png if the logo is not updated. I can't find where the logo.png OFS.Image is used so maybe it is already handled under the hood.

[mauritsvanrees]

It is not a problem if the images are used. But if we find that core does not use them, then now would be a good time to get rid of them, especially if this would be the last skin layer in use.

[yurj]

I think logo.png is used @agitator do you agree?

[agitator]

Few things...

• Should we switch to a default (svg) logo within the site control panel?
• And if there's no logo to not display a logo at all?
• Use https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/browser/sitelogo.py everywhere? -https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/browser/favicon.py isn't used if a file/image is accessed directly - removing the file system or skin layer versions should fix that too
• social meta tag should use that too <meta property="og:image" content="https://6-classic.demo.plone.org/logo.png">

[jensens]

see also https://github.com/plone/Products.CMFPlone/issues/1801