plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
254 stars 191 forks source link

Why is err_log_id defined in error_message.pt, but not used in the template itself? #3649

Open idgserpro opened 2 years ago

idgserpro commented 2 years ago

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

What I did:

In Plone 4, we used to have a err_log_id with tracebacks shown to non manager users in case of errors:

https://github.com/plone/Products.CMFPlone/blob/4.3.20/Products/CMFPlone/skins/plone_templates/default_error_message.pt#L147

We still have this variable defined in Plone5/6 template https://github.com/plone/Products.CMFPlone/blob/c3e9a33b9881c9dc7e35d459ccd3c4303acb2295/Products/CMFPlone/browser/templates/error_message.pt#L13 but now it's not used anywhere.

What I expect to happen:

Since err_log_id is defined in the template, I was expecting it to be printed somehow to non Manager users like previous Plone versions.

What actually happened:

No err_log_id is printed although is defined in the template. So the question is: is this a bug or intended behavior to remove printing this id since it's not even defined in it's view?

https://github.com/plone/Products.CMFPlone/blob/c3e9a33b9881c9dc7e35d459ccd3c4303acb2295/Products/CMFPlone/browser/exceptions.py#L12

What version of Plone/ Addons I am using:

Plone 5.2.7

jensens commented 1 year ago

In Plone 6 the template does not exist anymore.