plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
254 stars 191 forks source link

Submit Button Actions Modal in Control Panel not working #3711

Open pabo3000 opened 1 year ago

pabo3000 commented 1 year ago

BUG

What I did:

Log in as admin, access control Panel, the actions menue. edit any action, click into the form field category, choose one. Try to submit the form with the button at the bottom of the form

What I expect to happen:

I expect the modal to close and any changes are saved.

What actually happened:

The modal does not close. Any changes are not saved.

What version of Plone/ Addons I am using:

Plain plone classic UI https://6-classic.demo.plone.org/@@actions-controlpanel I tested it in Firefox and Chrome.

1letter commented 1 year ago

I think the change of category is not permitted. If you change the "number of position" then the save action is valid. Better error handlng is needed

petschki commented 1 year ago

The browser console returns {"error_type": "ValueError"} for the XHR ... as @1letter said changeing the category might not be permitted now. But then the field should be omitted in IEditForm at least. Or the handler should be able to move actions from one category to another.

Hareesh108 commented 1 year ago

Hi @pabo3000 ,

I would like to work on this issue. Can you please assign it to me? Thank you!