search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 187 forks source link

p.a.layout depends on CMFPlone #3761

Open gforcada opened 1 year ago

gforcada commented 1 year ago

Is someone surprised? 😆

With https://github.com/plone/plone.app.layout/pull/334 that adds plone/meta configuration to it, the only few imports from CMFPlone on plone.app.layout are only:

plone/app/layout/viewlets/common.py:20:from Products.CMFPlone.utils import getSiteLogo
plone/app/layout/viewlets/social.py:7:from Products.CMFPlone.browser.syndication.adapters import BaseItem
plone/app/layout/viewlets/social.py:8:from Products.CMFPlone.browser.syndication.adapters import FolderFeed
plone/app/layout/viewlets/social.py:9:from Products.CMFPlone.utils import getSiteLogo

The syndication related imports, I remember seeing that other distributions do also depend on them, so it might be worth moving it to plone.base 🤔 as for the getSiteLogo seems to be an easy candidate to be moved there as well.