search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
252 stars 188 forks source link

Config with default template #3775

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Only formatting and QA so far 😅

There are plenty of commits, but ignore the black one that is huuuuuuge.

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 1 year ago

Gah, wrong browser tab! I did not mean to merge this yet.

mauritsvanrees commented 1 year ago

I am undoing this with @davisagli. We have force pushed to the previous state (after temporarily allowing force pushing.) Sorry! I will recreate the PR.

mauritsvanrees commented 1 year ago

I opened a new PR #3776.