search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 187 forks source link

Remove the plone.app.multilingual dependency #3780

Closed folix-01 closed 1 year ago

folix-01 commented 1 year ago

Related to https://github.com/plone/Products.CMFPlone/issues/3779

mister-roboto commented 1 year ago

@folix-01 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

folix-01 commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

Wait, if I use the coredev buildout and start the instance, it fails with an ImportError in plone.restapi. So this cannot be merged yet. I will add a comment to issue #3779.