search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 188 forks source link

fix use the same default value for msgid #3804

Closed erral closed 1 year ago

erral commented 1 year ago

We are already using this msgid in plone.app.layout with a different default message, so with this PR we unify them both.

mister-roboto commented 1 year ago

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

erral commented 1 year ago

@jenkins-plone-org please run jobs

erral commented 1 year ago

It looks like the wrong one is the other.