search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 188 forks source link

Fix unstable robot test scenario Reorder Folder Contents. #3812

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Fixes https://github.com/plone/Products.CMFPlone/issues/3811 by waiting until elements are visible.

mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

Does it need to be ported to the master branch as well?

Yes. But there are no differences yet between 6.0.x and master, so I just merged 6.0.x to master and pushed. For now that is easiest and still seems safe, even without doing a PR.

gforcada commented 1 year ago

playwright is coming soon, I ported the plone.app.discussion tests already, and fixed/enhanced them on the way. Next important part would be to enable Jenkins to run them as well 😄