search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 188 forks source link

Do not use `UniqueObject` for `PloneSite` #3822

Closed petschki closed 1 year ago

petschki commented 1 year ago

Talking at the ArtSprint in Vienna: if you have a Plone site with lowercase Id you cannot add any object with the same Id in the whole zope instance. Trying to get rid of that here.

fixes #3823

mister-roboto commented 1 year ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@jenkins-plone-org please run jobs

jaroel commented 1 year ago

Ok, so that's what UniqueObject does! :)

gforcada commented 1 year ago

Do we need an upgrade step for this? 🤔

davisagli commented 1 year ago

Do we need an upgrade step for this? 🤔

It didn't change any persistent data, did it? So no.