search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
245 stars 188 forks source link

Un-remove IContentish from site root class #3833

Closed jaroel closed 10 months ago

jaroel commented 1 year ago

On https://github.com/plone/Products.CMFPlone/blob/016459fd9d023017e9dc0a0b635bd66099826db1/Products/CMFPlone/Portal.py#L214 I remove IContentish, because having it broke tests and setup code in places that I didn't feel like touching.

Nowadays we have some test failures because of the removal. See https://github.com/plone/plone.restapi/pull/1674#issuecomment-1664193927 for additional details, but suffice to say that conversation_view is expected to exist on the site root, but isn't because it's bound to IContentish.

jaroel commented 11 months ago

The removal of IContentish seems to also remove plone.app.relationfield.interfaces.IDexterityHasRelations (for PloneSite) . Which is weird to me because IDexterityHasRelations is set on the class plone.dexterity.context.Content, not as a subclass of IContentish.