search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

fix: avoid searching all users when many_users is flagged #3845

Closed mamico closed 10 months ago

mamico commented 11 months ago

Despite the many_user flag checked, after an action for add or remove user in a group, a search is done without any filter. Where, for example Plone has a connected ldap with many users, this is a problem.

mister-roboto commented 11 months ago

@mamico thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mamico commented 11 months ago

@jenkins-plone-org please run jobs

mamico commented 11 months ago

@jenkins-plone-org please run jobs

mamico commented 10 months ago

@jenkins-plone-org please run jobs