search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

Content ID check should be more strict (it allows to break objects) #3847

Closed szakitibi closed 8 months ago

szakitibi commented 10 months ago

The same fix is already there for Plone 6.

mister-roboto commented 10 months ago

@szakitibi you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

mister-roboto commented 10 months ago

@szakitibi thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mister-roboto commented 10 months ago

@szakitibi you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

szakitibi commented 10 months ago

@szakitibi you need to sign the Plone Contributor Agreement to merge this pull request.

This is a copy of an existing fix. All the credit and copyright stuff should go for @laulaz.

szakitibi commented 8 months ago

@jenkins-plone-org please run jobs