search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

Fixup explicitacquisition #3855

Closed jaroel closed 10 months ago

jaroel commented 10 months ago

We need to explicitly set the SKIP_PTA flag as it is set on module load.

mister-roboto commented 10 months ago

@jaroel thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jaroel commented 10 months ago

@jenkins-plone-org please run jobs

jaroel commented 10 months ago

@jenkins-plone-org please run jobs

jaroel commented 10 months ago

@jenkins-plone-org please run jobs

jaroel commented 10 months ago

I think this is because we don't have the plone.rest branch checked out. https://jenkins.plone.org/job/pull-request-6.1-3.11/308/ should run with both, and the plone.rest build is green.