search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

undo icontentish interface in 6.0.x #3856

Closed Akshat2Jain closed 9 months ago

Akshat2Jain commented 10 months ago

this pr is related to #3836

mister-roboto commented 10 months ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Akshat2Jain commented 10 months ago

@wesleybl

wesleybl commented 10 months ago

@jenkins-plone-org please run jobs

wesleybl commented 10 months ago

@jenkins-plone-org please run jobs

Akshat2Jain commented 9 months ago

@wesleybl some test are still failing

davisagli commented 9 months ago

@Akshat2Jain @wesleybl I think this is probably too big a change to make for Plone 6.0, since it was already released some time ago. If someone is depending on the fact that the Plone site does not provide the IContentish interface, then it is a breaking change. So, I would keep it for Plone 6.1 only and not do this backport.