Closed jairhenrique closed 10 months ago
@jairhenrique you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement
@jairhenrique thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
@jenkins-plone-org please run jobs
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!
@jairhenrique you need to sign the Plone Contributor Agreement to merge this pull request.
Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement
@jairhenrique thanks for your contribution to Products.CMFPlone! 🎉
Seems that you have not signed the contributor agreement, would you mind doing that? On the comment above there is a link with all the information about it 🍀
Let us know when you have done it! Otherwise, for this small patch we can accept it without the contributor agreement, but as we would love to have more contributions from you, the agreement would greatly help 😄
@gforcada I've already signed, but I don't know why it's not enabled here 🤔
@jairhenrique sorry, I was late in processing contributor agreements, with travels from Plone conference, should be fixed in a minute.
@jenkins-plone-org please run jobs
@jairhenrique Please add a changelog entry in the news
folder. (See https://6.docs.plone.org/contributing/index.html#change-log-entry)
@davisagli I missed some kind of extension like removal
or misc
, so I considered this change as internal
, does that make sense?
Remove unnecessary dependency. Mock is builtin since python 3.3.