search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

Plone Classic: Inconsistencies in field validation styling and classes #3865

Open Nimo-19 opened 10 months ago

Nimo-19 commented 10 months ago

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

I recently wanted to improve the visibility of invalid fields for my editors, but stumbled upon some inconsistencies in the styling of invalid fields. Don't know if this is the right place for this. Please point me in a direction if it is not.

What I did:

I triggered three validation-errors on: https://classic.demo.plone.org

  1. Required: ++add++Event: Tab through Empty title and get a 'Please fill out this field' Message
  2. Validation of URL-field: ++add++Event: Type rubbish into the 'Event URL' field, submit and get 'The specified URI is not valid.' Message
  3. Validation of JSON-field: /@@tinymce-controlpanel and type rubbish into 'Formats' field.

What I expect to happen:

All fields to have the roughly the same CSS classes and styling for displaying error messages.

What actually happened:

  1. Displays only the error messags, no other CSS classes present for indication an error
  2. Actually has the .error class on the div.field and an .is-invalid class on the input. The .is-invalid styles the input with a red border.
  3. Only has the .error class on the div.field No red border around the textarea field.

What version of Plone/ Addons I am using:

https://classic.demo.plone.org which seems to be Plone 6.0.6 atm.