search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
243 stars 186 forks source link

Correct the behavior interface for lead image in the syndication adaper. #3877

Closed thet closed 8 months ago

mister-roboto commented 8 months ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 8 months ago

@jenkins-plone-org please run jobs

gforcada commented 8 months ago

If I get this right, for at least 9 years this import has been this way: https://github.com/plone/Products.CMFPlone/blame/3d03cf9d7fef121461ff1c6f50a6d72196fada87/Products/CMFPlone/browser/syndication/adapters.py

If it has never failed, is because we don't have test coverage for this case? 🤔

Or rather since this change was made in 2018 to rename ILeadImage to ILeadImageBehavior.

Or, am I missing something else? 😅

Otherwise the change looks good! 👍🏾