search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
249 stars 188 forks source link

Fix robot test "When page is linked show warning" #3904

Closed wesleybl closed 7 months ago

wesleybl commented 7 months ago

Backport of #3902 to 6.0

mister-roboto commented 7 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

wesleybl commented 7 months ago

@jenkins-plone-org please run jobs

wesleybl commented 7 months ago

Is Plone 6.0 not tested with Python 3.12?

jensens commented 7 months ago

Is Plone 6.0 not tested with Python 3.12?

No, this is a 6.1 feature and tested only on the master branch, your PR is against 6.0.x branch.

wesleybl commented 7 months ago

I found it strange because support for Python 3.12 is declared in Plone 6.0, but it is not tested in that version. Maybe the tests should be in Python 3.12 instead of 3.11.

stevepiercy commented 7 months ago

@wesleybl see https://plone.org/download/release-schedule:

Supported versions

Plone 6.0

...

  • Supports Python 3.8, 3.9, 3.10, 3.11. Plone 6.0.9 should work fine on 3.12, official support is expected to land in 6.0.10.
mauritsvanrees commented 7 months ago

PRs for Plone 6.0 are tested on Python 3.8 and 3.11, just like the 6.0 coredev branch when something is committed there.

There are jobs for 3.9, 3.10 and 3.12, but these are only run once a week. This avoids running lots of jobs where there is very little chance of something going wrong. See the Core schedules tab on Jenkins.

We might start testing on 3.12 instead of 3.11 by default at some point.