Editing a images alignment in TinyMCE duplicates the image

plone / Products.CMFPlone

The core of the Plone content management system

https://plone.org

GNU General Public License v2.0

249 stars 188 forks source link

Editing a images alignment in TinyMCE duplicates the image #3910

Closed pbauer closed 7 months ago

pbauer commented 7 months ago

Tested in 6.0.9, 6.0 coredev and 6.1 coredev. For me it only happens in Firefox, not in Chrome

To reproduce:

Add a image to a page in TinyMCE and select Align Left
Edit the same image (select it with a click and click "Insert Image")
Change Align to Right
Save
You now have two images (one right, one left)

duplicate

pbauer commented 7 months ago

Same issue: Selecting the image via click and pressing "delete" does not remove the image.

Both problems do not happen when selecting the img-tag in status bar before deleting or changing something: tag

My guess is that the mage-plugin somehow does not select the correct element upon click.

pbauer commented 7 months ago

@petschki maybe this is also up your alley :)

petschki commented 7 months ago

I remember this behavior some time ago. I think @mauritsvanrees had some similary issues. Thought we fixed that meanwhile. I try to figure out whats going on.

petschki commented 7 months ago

I fixed an issue here https://github.com/plone/mockup/commit/856b519c8f598aa93d629d1b786984c7b08e7db3 but this was there for some reason ;)

petschki commented 7 months ago

Fixed in

plone.staticresources==2.1.12 (Plone 6.0)
plone.staticresources==2.2.0a5 (Plone 6.1)

mauritsvanrees commented 7 months ago

My earlier report with the same problem was issue #3800. I confirm this is fixed with the new version. Thanks! I will include the new version in Plone 6.0.10 today.