search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
249 stars 188 forks source link

Cleanup viewlets.xml to not mention viewlets that no longer exist. #3913

Closed mauritsvanrees closed 7 months ago

mauritsvanrees commented 7 months ago

Nothing really goes wrong with non-existing viewlets, but it is confusing. Fixes https://github.com/plone/Products.CMFPlone/issues/3911

Forward port of the already merged PR #3912.

mister-roboto commented 7 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 7 months ago

@jenkins-plone-org please run jobs