search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
249 stars 188 forks source link

Bugfix for getIcon indexer and conflicting "image" id #3917

Closed frapell closed 7 months ago

frapell commented 7 months ago

This PR fixes https://github.com/plone/Products.CMFPlone/issues/3916

mister-roboto commented 7 months ago

@frapell thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

frapell commented 7 months ago

@jenkins-plone-org please run jobs