Closed wesleybl closed 3 months ago
@wesleybl thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
@jenkins-plone-org please run jobs
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!
@jenkins-plone-org please run jobs
Just a note: @mauritsvanrees added the keywords Wait for Element
and Wait for then click element
in https://github.com/plone/plone.app.robotframework/blob/master/src/plone/app/robotframework/selenium.robot#L99 which fixed several flaky tests in CMFPlone robot tests ... there'S also aWait for Elements
which does the same for multiple elements.
@petschki the error here was not a lack of waiting. The wait command did not detect the element, even with the element on the screen. So I think the commands you indicated would also fail.
Anyway, thanks for pointing out the commands!
Fix intermittent failure in test robot. Sometimes waiting for the element with the
itemRow
class fails despite it being on the screen. So we wait 1 second instead of waiting for the element.Fix: https://jenkins.plone.org/job/pull-request-6.1-3.10/2/robot/report/robot_log.html#s1-s9-t1