search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
240 stars 183 forks source link

we do not need to depend on CMFEditions here #3957

Closed jensens closed 1 month ago

jensens commented 1 month ago

plone.app.iterate as a core-addon should be the only one depending on Products.CMFEditions. All related tests and so on should go there. It is okayish to have the exclusions by string in here.

mister-roboto commented 1 month ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 month ago

@jenkins-plone-org please run jobs